[coreboot-gerrit] Change in ...coreboot[master]: intelblocks/systemagent: Add ACPI table generation hook

[Werner Zeh (Code Review)]

Werner Zeh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30989 )

Change subject: intelblocks/systemagent: Add ACPI table generation hook
......................................................................

Patch Set 2:

(1 comment)

https://review.coreboot.org/#/c/30989/2/src/soc/intel/common/block/include/i... 
File src/soc/intel/common/block/include/intelblocks/acpi.h:

https://review.coreboot.org/#/c/30989/2/src/soc/intel/common/block/include/i... 
PS2, Line 79: const
> Agree, will change.

Wait a moment, in device/device.h the function prototype for this hook does not use const at all:

unsigned long (*write_acpi_tables)(struct device *dev,
    	unsigned long start, struct acpi_rsdp *rsdp);

In addition, it is inside the "#if IS_ENABLED(CONFIG_HAVE_ACPI_TABLES)" switch which I would like to add to my code as well.