[coreboot-gerrit] Change in coreboot[master]: soc/amd/picasso/acpi: Fix hang caused by IVRS

[Aaron Durbin (Code Review)]

Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45050 )

Change subject: soc/amd/picasso/acpi: Fix hang caused by IVRS
......................................................................

Patch Set 3:

(2 comments)

https://review.coreboot.org/c/coreboot/+/45050/3/src/soc/amd/picasso/acpi.c 
File src/soc/amd/picasso/acpi.c:

https://review.coreboot.org/c/coreboot/+/45050/3/src/soc/amd/picasso/acpi.c@... 
PS3, Line 64: 			CONFIG_MAX_CPUS + 1, nb_ioapic_base, 32);
You should probably use a local variable called apic_id or something and assign it CONFIG_MAX_CPUS + 1 w/ a comment indicating the reasoning.

https://review.coreboot.org/c/coreboot/+/45050/3/src/soc/amd/picasso/acpi.c@... 
PS3, Line 64: 32
Is it always 32? Should we have some defines for how many IRQs are supported in each apic?