Duncan Laurie has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41209 )
Change subject: fw_config: Add firmware configuration interface
......................................................................
Patch Set 1:
I try to avoid introducing new top-level interfaces if possible, but to do probing it really needs integration in both drivers and mainboards and it seemed that src/lib was the best location.
I decided to follow the naming that was used when defining this interface in the EC and the factory process so it would be clear when working with coreboot what it affects. That said 'firmware configuration' is a pretty generic term and there may be other opinions on how to name it.
The first board to use this interface is volteer, but it will get added for other new boards soon.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/41209
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I1e889c235a81545e2ec0e3a34dfa750ac828a330
Gerrit-Change-Number: 41209
Gerrit-PatchSet: 1
Gerrit-Owner: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Jett Rink
jettrink@chromium.org
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Stefan Reinauer
reinauer@chromium.org
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Comment-Date: Sun, 10 May 2020 18:48:13 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment