Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32363 )
Change subject: pcengines/apu2: implement POSTCAR_STAGE ......................................................................
Patch Set 11:
(7 comments)
https://review.coreboot.org/c/coreboot/+/32363/4//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/32363/4//COMMIT_MSG@9 PS4, Line 9: was
is
Done
https://review.coreboot.org/c/coreboot/+/32363/4//COMMIT_MSG@11 PS4, Line 11:
Please elaborate. […]
Done
https://review.coreboot.org/c/coreboot/+/32363/4//COMMIT_MSG@12 PS4, Line 12: since
starting
Done
https://review.coreboot.org/c/coreboot/+/32363/4/src/mainboard/pcengines/apu... File src/mainboard/pcengines/apu2/postcar.c:
https://review.coreboot.org/c/coreboot/+/32363/4/src/mainboard/pcengines/apu... PS4, Line 22: outb(0xEA, 0xCD6); : outb(0x1, 0xcd7);
We generally use lower case, right. […]
Done
https://review.coreboot.org/c/coreboot/+/32363/6/src/mainboard/pcengines/apu... File src/mainboard/pcengines/apu2/postcar.c:
https://review.coreboot.org/c/coreboot/+/32363/6/src/mainboard/pcengines/apu... PS6, Line 21: /* Disable PCI-PCI bridge and release GPIO32/33 for other uses. */ : outb(0xea, 0xcd6); : outb(0x1, 0xcd7);
Removed
Done
https://review.coreboot.org/c/coreboot/+/32363/6/src/mainboard/pcengines/apu... File src/mainboard/pcengines/apu2/romstage.c:
https://review.coreboot.org/c/coreboot/+/32363/6/src/mainboard/pcengines/apu... PS6, Line 79: console_init();
Indeed. […]
Done
https://review.coreboot.org/c/coreboot/+/32363/6/src/mainboard/pcengines/apu... PS6, Line 80: : /* Load MPB */ : val = cpuid_eax(1); : printk(BIOS_DEBUG, "BSP Family_Model: %08x\n", val);
Actually it's not. Was present earlier but not needed at all.
Done