Attention is currently required from: Frank Wu, Hung-Te Lin, Ian Feng, John Su, Shawn Ku, Shawn Ku, Yidi Lin.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81791?usp=email )
The change is no longer submittable: All-Comments-Resolved is unsatisfied now.
Change subject: mb/google/corsola: Add new board Veluza
......................................................................
Patch Set 3:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/81791/comment/b09d4dc5_7b7715c1 :
PS3, Line 7: mb/google/corsola: Add new board Veluza
Should *variant* be mentioned in the title?
File src/mainboard/google/corsola/Kconfig:
https://review.coreboot.org/c/coreboot/+/81791/comment/1ba24e4f_28ee4c5f :
PS3, Line 93: default "Veluza" if BOARD_GOOGLE_VELUZA
Is there a reason, this list list is not sorted?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/81791?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Idedcbfbddd6d98a51cf28a0963d68f6d8c68382c
Gerrit-Change-Number: 81791
Gerrit-PatchSet: 3
Gerrit-Owner: Frank Wu
frank_wu@compal.corp-partner.google.com
Gerrit-Reviewer: Eric Lai
ericllai@google.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Ian Feng
ian_feng@compal.corp-partner.google.com
Gerrit-Reviewer: John Su
john_su@compal.corp-partner.google.com
Gerrit-Reviewer: Shawn Ku
shawnku@chromium.org
Gerrit-Reviewer: Yidi Lin
yidilin@google.com
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Jasper Lee
jasper_lee@compal.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Shawn Ku
shawnku@google.com
Gerrit-CC: Van Chen
van_chen@compal.corp-partner.google.com
Gerrit-Attention: Frank Wu
frank_wu@compal.corp-partner.google.com
Gerrit-Attention: Hung-Te Lin
hungte@chromium.org
Gerrit-Attention: John Su
john_su@compal.corp-partner.google.com
Gerrit-Attention: Ian Feng
ian_feng@compal.corp-partner.google.com
Gerrit-Attention: Shawn Ku
shawnku@google.com
Gerrit-Attention: Shawn Ku
shawnku@chromium.org
Gerrit-Attention: Yidi Lin
yidilin@google.com
Gerrit-Comment-Date: Fri, 12 Apr 2024 09:49:34 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment