[coreboot-gerrit] Change in ...coreboot[master]: util/ifdtools: Make EC region readable to BIOS/CPU

[Duncan Laurie (Code Review)]

Duncan Laurie has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31377 )

Change subject: util/ifdtools: Make EC region readable to BIOS/CPU
......................................................................

Patch Set 1:

(1 comment)

https://review.coreboot.org/#/c/31377/1/util/ifdtool/ifdtool.c 
File util/ifdtool/ifdtool.c:

https://review.coreboot.org/#/c/31377/1/util/ifdtool/ifdtool.c@973 
PS1, Line 973: 10
> Wondering if this should be behind a Kconfig option. […]

It does seem harmless if there is no EC region.  In general it would be nice if this tool was more flexible with the permission settings it applies..

It so happens I need the EC region readable for software sync so this is useful, but I could see a scenario where someone would not want the EC to be readable.  (not that security by obscurity is going to stop anything)