Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47396 )
Change subject: soc/intel/tigerlake: Check TBT & TCSS ports for wake events
......................................................................
Patch Set 5:
(1 comment)
https://review.coreboot.org/c/coreboot/+/47396/5/src/soc/intel/tigerlake/elo...
File src/soc/intel/tigerlake/elog.c:
https://review.coreboot.org/c/coreboot/+/47396/5/src/soc/intel/tigerlake/elo...
PS5, Line 96: pci_dev_is_wake_source
Not for this change, but I think we need to add a check in pci_dev_is_wake_source to ensure that the […]
I think the header type check in pci_s_find_next_capability will effectively do that, but it doesn't hurt to be explicit either.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/47396
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie9904c3c01ea85fcd83218fcfeaa4378b07c1463
Gerrit-Change-Number: 47396
Gerrit-PatchSet: 5
Gerrit-Owner: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: Caveh Jalali
caveh@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 02 Dec 2020 21:47:47 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Gerrit-MessageType: comment