Attention is currently required from: CoolStar, Jason Nien, Martin Roth, Martin Roth, Nico Huber, Paul Menzel.
Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78406?usp=email )
Change subject: mb/google/kahlee: Rework I2S/ACP ACPI for new Windows driver
......................................................................
Patch Set 4: Code-Review+1
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/78406/comment/bdc8adbf_d6f6517a :
PS2, Line 9: Supports a brand new ACP driver for STONEY / Grunt chromebooks.
I’d be great if you added some version information.
version info for what component?
File src/mainboard/google/kahlee/variants/baseboard/include/baseboard/acpi/audio_common.asl:
https://review.coreboot.org/c/coreboot/+/78406/comment/fc10e106_9690c363 :
PS4, Line 5: {
move bracket to new line
--
To view, visit
https://review.coreboot.org/c/coreboot/+/78406?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I51527a1bfae3e12ce5cf1da8a3465bbc9ddfa76e
Gerrit-Change-Number: 78406
Gerrit-PatchSet: 4
Gerrit-Owner: CoolStar
coolstarorganization@gmail.com
Gerrit-Reviewer: Jason Nien
jason.nien@amd.corp-partner.google.com
Gerrit-Reviewer: Martin Roth
martin.roth@amd.corp-partner.google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Martin Roth
martinroth@google.com
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Jason Nien
jason.nien@amd.corp-partner.google.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: CoolStar
coolstarorganization@gmail.com
Gerrit-Attention: Martin Roth
martin.roth@amd.corp-partner.google.com
Gerrit-Comment-Date: Mon, 16 Oct 2023 17:56:35 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Paul Menzel
paulepanter@mailbox.org
Gerrit-MessageType: comment