build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34930 )
Change subject: amdfam10: Drop spurious #ifdef __PRE_RAM__ ......................................................................
Patch Set 3:
(2 comments)
https://review.coreboot.org/c/coreboot/+/34930/3/src/southbridge/amd/cimx/sb... File src/southbridge/amd/cimx/sb900/cfg.c:
https://review.coreboot.org/c/coreboot/+/34930/3/src/southbridge/amd/cimx/sb... PS3, Line 247: if (ENV_RAMSTAGE && !sb_config->StdHeader.CALLBACK.CalloutPtr) { braces {} are not necessary for single statement blocks
https://review.coreboot.org/c/coreboot/+/34930/3/src/southbridge/amd/cimx/sb... PS3, Line 252: printk(BIOS_INFO, "SB900 - Cfg.c - sb900_cimx_config - End.\n"); Prefer using '"%s...", __func__' to using 'sb900_cimx_config', this function's name, in a string