[coreboot-gerrit] Change in ...coreboot[master]: mb/google/hatch: Add GPIO_A8 for Pen detect function

[Furquan Shaikh (Code Review)]

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31815 )

Change subject: mb/google/hatch: Add GPIO_A8 for Pen detect function
......................................................................

Patch Set 4:

(1 comment)

https://review.coreboot.org/#/c/31815/3/src/mainboard/google/hatch/variants/... 
File src/mainboard/google/hatch/variants/baseboard/devicetree.cb:

https://review.coreboot.org/#/c/31815/3/src/mainboard/google/hatch/variants/... 
PS3, Line 236: ACPI_GPIO_INPUT_ACTIVE_LOW
> Pen in chromebook => GPP_A8=High , Pen not in chromebook => GPP_A8=Low

This signal is pen inserted. Since GPP_A8 is high when pen is inserted in chromebook, this gpio should be configured to ACPI_GPIO_INPUT_ACTIVE_HIGH.

What does evtest look like when you insert/eject pen?