Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45588 )
Change subject: spd: move weak mainboard_get_dram_part_num implementation to lib/spd_bin.c
......................................................................
Patch Set 20:
(2 comments)
https://review.coreboot.org/c/coreboot/+/45588/20/src/lib/spd_bin.c
File src/lib/spd_bin.c:
https://review.coreboot.org/c/coreboot/+/45588/20/src/lib/spd_bin.c@146
PS20, Line 146: char spd_name[]
This is not really required anymore. You can just return &spd[offset]; […]
Actually this change should be made in CB:45459
https://review.coreboot.org/c/coreboot/+/45588/20/src/lib/spd_bin.c@170
PS20, Line 170: print_spd_info
None of the changes in this function should be part of this CL. They should move to CB:45459
--
To view, visit
https://review.coreboot.org/c/coreboot/+/45588
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie173b81b9c9a98f3744cc9da4b034d2251f5589b
Gerrit-Change-Number: 45588
Gerrit-PatchSet: 20
Gerrit-Owner: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Aaron Durbin
adurbin@chromium.org
Gerrit-CC: Furquan Shaikh
furquan@google.com
Gerrit-CC: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Comment-Date: Thu, 24 Sep 2020 20:00:26 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Gerrit-MessageType: comment