[coreboot-gerrit] Change in coreboot[master]: drivers/smmstore: Implement SMMSTORE version 2

[Angel Pons (Code Review)]

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40520 )

Change subject: drivers/smmstore: Implement SMMSTORE version 2
......................................................................

Patch Set 23:

(1 comment)

https://review.coreboot.org/c/coreboot/+/40520/21/src/commonlib/include/comm... 
File src/commonlib/include/commonlib/coreboot_tables.h:

https://review.coreboot.org/c/coreboot/+/40520/21/src/commonlib/include/comm... 
PS21, Line 492: struct lb_smmstorev2 {
              : 	uint32_t tag;
              : 	uint32_t size;
              : 	uint32_t num_blocks;		/* Number of writeable blocks in SMM */
              : 	uint32_t block_size;		/* Size of a block in byte. Default: 64 KiB */
              : 	uint32_t mmap_addr;		/* MMIO address of the store for read only access */
              : 	uint32_t com_buffer;		/* Physical address of the communication buffer */
              : 	uint32_t com_buffer_size;	/* Size of the communication buffer in bytes */
              : 	uint8_t apm_cmd;		/* The command byte to write to the APM I/O port */
              : 	uint8_t unused[3];		/* Set to zero */
              : };
> Not for now, but as a future idea it is doable. […]

It's meant for bootloader use, but OSes could use SMMSTORE as well. However, I imagine OSes would have better places to save stuff into than the flash chip.