Attention is currently required from: Raul Rangel, Jon Murphy, Mark Hasemeyer.
Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74099 )
Change subject: mb/google/myst: Enable chromeOS EC
......................................................................
Patch Set 19: Code-Review+2
(1 comment)
File src/mainboard/google/myst/dsdt.asl:
https://review.coreboot.org/c/coreboot/+/74099/comment/8b1eff2b_f416cc0a
PS19, Line 18: Name (LIDS, 0)
I have uploaded a CL to explore the possibility of removing this ACPI object - CB:74332. If that gets accepted, then we can remove it from all google mainboards atleast. Until that points, let us keep it around.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/74099
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id18a311097d575973087eb92fd446a5c511f570e
Gerrit-Change-Number: 74099
Gerrit-PatchSet: 19
Gerrit-Owner: Jon Murphy
jpmurphy@google.com
Gerrit-Reviewer: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Mark Hasemeyer
markhas@google.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: Tim Van Patten
timvp@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Raul Rangel
rrangel@chromium.org
Gerrit-Attention: Jon Murphy
jpmurphy@google.com
Gerrit-Attention: Mark Hasemeyer
markhas@google.com
Gerrit-Comment-Date: Mon, 10 Apr 2023 21:18:40 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment