Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32788 )
Change subject: soc/intel/common/block/gpio: Add gpio_pm_configure() function ......................................................................
Patch Set 2:
(3 comments)
https://review.coreboot.org/#/c/32788/2/src/soc/intel/common/block/gpio/Kcon... File src/soc/intel/common/block/gpio/Kconfig:
https://review.coreboot.org/#/c/32788/2/src/soc/intel/common/block/gpio/Kcon... PS2, Line 47: SOC_INTEL_DISABLE_DYNAMIC_CLOCK_LOCAL_GATING
Can you please add some help text indicating what this option is used for?
Done
https://review.coreboot.org/#/c/32788/2/src/soc/intel/common/block/gpio/gpio... File src/soc/intel/common/block/gpio/gpio.c:
https://review.coreboot.org/#/c/32788/2/src/soc/intel/common/block/gpio/gpio... PS2, Line 625: gpio_pm_configure
Can this function just accept a mask and value that it should use to set in the misccfg registers ra […]
I thought we need this solution for time being till cr50 FW actually updated with recommended IRQ pulse ?
I still prefer to make use of this functionality and allow complete GPIO PM programming for all community.
As i understand, you might wish to skip certain community to set dynamic clock local programming, in that case, we can make use of another Kconfig to tell which GPIO PIN you wish to skip ?
https://review.coreboot.org/#/c/32788/2/src/soc/intel/common/block/gpio/gpio... PS2, Line 638: if (!CONFIG(SOC_INTEL_DISABLE_DYNAMIC_CLOCK_LOCAL_GATING))
This condition is the same as the 'else' clause above. […]
Done