Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35502 )
Change subject: sc7180: Add AOP firmware support
......................................................................
Patch Set 11: Code-Review+2
(1 comment)
https://review.coreboot.org/c/coreboot/+/35502/11/src/soc/qualcomm/sc7180/in...
File src/soc/qualcomm/sc7180/include/soc/memlayout.ld:
https://review.coreboot.org/c/coreboot/+/35502/11/src/soc/qualcomm/sc7180/in...
PS11, Line 70: REGION(dram_aop, 0x80800000, 0x040000, 0x1000)
SDM845 didn't have this, what is this? Can we make it contiguous with the other reserved area?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/35502
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I1cd552fbf03b5135e5911f1143f8778cad81e360
Gerrit-Change-Number: 35502
Gerrit-PatchSet: 11
Gerrit-Owner: mturney mturney
mturney@codeaurora.org
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: ashk@codeaurora.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: mturney mturney
mturney@codeaurora.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 29 Oct 2019 23:00:45 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment