Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46447 )
Change subject: soc/mediatek/mt8192: Keep CONN MCU in reset state
......................................................................
Patch Set 44:
(2 comments)
https://review.coreboot.org/c/coreboot/+/46447/44//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/46447/44//COMMIT_MSG@10
PS44, Line 10: asserting
This can fit in the previous line.
https://review.coreboot.org/c/coreboot/+/46447/44/src/soc/mediatek/mt8192/pl...
File src/soc/mediatek/mt8192/pll.c:
https://review.coreboot.org/c/coreboot/+/46447/44/src/soc/mediatek/mt8192/pl...
PS44, Line 468: 1
0x1
--
To view, visit
https://review.coreboot.org/c/coreboot/+/46447
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia1b706da497ba2827341051459c3628e2ae9240f
Gerrit-Change-Number: 46447
Gerrit-PatchSet: 44
Gerrit-Owner: Yidi Lin
yidi.lin@mediatek.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Weiyi Lu
weiyi.lu@mediatek.com
Gerrit-Reviewer: Xi Chen
xixi.chen@mediatek.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: pan gao
gtk_pangao@mediatek.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-CC: Yu-Ping Wu
yupingso@google.com
Gerrit-Comment-Date: Mon, 14 Dec 2020 07:00:57 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment