Pavel Sayekat has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38782 )
Change subject: superio/nuvoton/nct5539d/acpi: fix # comment in superio.asl ......................................................................
Patch Set 5:
(1 comment)
Patch Set 4: Code-Review+1
Patch Set 4:
oh, seems that i messed that up during the spdx header conversion. would be good to have a board in the coreboot tree using this super io so jenkins/abuild can catch these sorts of bugs
This SIO was saved from removal because CB:34603 is using it. However, it was not build-tested so well, things happen.
Ok, I get it (no, I didn't). But does that make it eligible to be merged?
https://review.coreboot.org/c/coreboot/+/38782/4/src/superio/nuvoton/nct5539... File src/superio/nuvoton/nct5539d/acpi/superio.asl:
https://review.coreboot.org/c/coreboot/+/38782/4/src/superio/nuvoton/nct5539... PS4, Line 1: #
remove the #
removed.