EricR Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48153 )
Change subject: soc/intel/alderlake: Align chipset.cb with pci_devs.h
......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/c/coreboot/+/48153/2/src/soc/intel/alderlake/chi...
File src/soc/intel/alderlake/chipset.cb:
https://review.coreboot.org/c/coreboot/+/48153/2/src/soc/intel/alderlake/chi...
PS2, Line 16: tcss_xhci off end
: device pci 0d.1 alias tcss_xdci off end
: device pci 0d.2 alias tcss_dma0 off end
: device pci 0d.3 alias tcss_dma1 off end
That's fine. FYI, it's from the old southbridge (slow I/O) / northbridge (fast I/O) distinction. […]
I knew this. The old school things lol. You can see fsp registers use the tscc_xhci..etc. This can help people to match fsp registers setting and the pci device in a clear way.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/48153
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iac33983dc12ed4e5b9257c50d82adc8e4e728ad6
Gerrit-Change-Number: 48153
Gerrit-PatchSet: 4
Gerrit-Owner: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.corp-partner.google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Subrata Banik
subrata.banik@intel.com
Gerrit-Comment-Date: Wed, 02 Dec 2020 04:29:15 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Tim Wawrzynczak
twawrzynczak@chromium.org
Comment-In-Reply-To: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-MessageType: comment