build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37466 )
Change subject: soc/intel/cannonlake: Add VR config for CFL and WHL
......................................................................
Patch Set 2:
(2 comments)
https://review.coreboot.org/c/coreboot/+/37466/2/src/soc/intel/cannonlake/vr...
File src/soc/intel/cannonlake/vr_config.c:
https://review.coreboot.org/c/coreboot/+/37466/2/src/soc/intel/cannonlake/vr...
PS2, Line 191: if (tdp >= 95) {
braces {} are not necessary for any arm of this statement
https://review.coreboot.org/c/coreboot/+/37466/2/src/soc/intel/cannonlake/vr...
PS2, Line 208: if (tdp >= 71) {
braces {} are not necessary for any arm of this statement
--
To view, visit
https://review.coreboot.org/c/coreboot/+/37466
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I1d2e174157d468830cc0baf2a2d8295ef61a1a63
Gerrit-Change-Number: 37466
Gerrit-PatchSet: 2
Gerrit-Owner: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Kane Chen
kane_chen@pegatron.corp-partner.google.com
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Shelley Chen
shchen@google.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Harry Pan
harry.pan@intel.com
Gerrit-CC: Jamie Chen
jamie.chen@intel.com
Gerrit-Comment-Date: Thu, 05 Dec 2019 07:59:30 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment