Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42770 )
Change subject: libpayload/cbgfx: Fix overflow in transform_vector()
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/42770/1//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/42770/1//COMMIT_MSG@16
PS1, Line 16: TEST=Previous screen is cleared properly for menu UI
Yes, the screen used to not clear before redrawing the next screen and we'd see artifacts.
Thanks for the confirmation. Could you please state the problem explicitly in the commit message?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/42770
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I57845f54e18e5bdbd0d774209ee9632cb860b0c2
Gerrit-Change-Number: 42770
Gerrit-PatchSet: 2
Gerrit-Owner: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: Joel Kitching
kitching@google.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Shelley Chen
shchen@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 25 Jun 2020 07:26:17 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Shelley Chen
shchen@google.com
Comment-In-Reply-To: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-MessageType: comment