Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33522 )
Change subject: src/mb/gigabyte/ga-h61m-s2pv: Correct devicetree
......................................................................
Patch Set 2: Code-Review+1
(1 comment)
https://review.coreboot.org/#/c/33522/2/src/mainboard/gigabyte/ga-h61m-s2pv/...
File src/mainboard/gigabyte/ga-h61m-s2pv/devicetree.cb:
https://review.coreboot.org/#/c/33522/2/src/mainboard/gigabyte/ga-h61m-s2pv/...
PS2, Line 96: irq 0xf1 = 0x40
I asked superiotool and these irq settings have been set as described here.
Ack, it seems the PNP_MSCx are only necessary for warnings when
they are left unset.
Though, it would be nice to have a comment for each non-standard
register here about what you set.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/33522
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ieb9dd8c835bc3652e7a3a118feca5551196bb81b
Gerrit-Change-Number: 33522
Gerrit-PatchSet: 2
Gerrit-Owner: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Sun, 16 Jun 2019 11:01:25 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Gerrit-MessageType: comment
