Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42786 )
Change subject: mb/amd: Add Pollock CRB Cereme as Mandolin variant ......................................................................
Patch Set 15:
(1 comment)
https://review.coreboot.org/c/coreboot/+/42786/15/src/mainboard/amd/mandolin... File src/mainboard/amd/mandolin/variants/cereme/devicetree.cb:
PS15:
Can an overridetree be used?
While this could be done, I intentionally didn't do this to make it easier to use Mandolin and Cereme as a starting point for another Picasso/Dali ("socket" FP5) or Pollock ("socket" FT5) based mainboard. FP5 and FT5 aren't interchangeable, so while certain silicon is put in both packages, it's still a different platform. There also has been an issue introduced by a devicetree override conversion on some old Thinkpad, so making this a devicetree override and then undoing that when creating a new board based on this creates additional risk of breaking things. This also mirrors what's done in mb/google/zork where we have a base devicetree for Picasso/Dali and one for Pollock; there are additional devicetree overrides for the different devices that are based on one of those two though.