Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33403 )
Change subject: nb/intel/nehalem: Die if no memory ranks found
......................................................................
Patch Set 1:
Replacing an unhandled exception (division by zero) with a die()
can't break anything more than it is already :)
Sure, why not?
Because it was already broken. As much as possible. Before this change,
in the `count == 0` case, execution stopped in line 1013. Just not with
a useful error message.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/33403
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I6146dd8420f3734d1a672a9f29a098f47fcb739c
Gerrit-Change-Number: 33403
Gerrit-PatchSet: 1
Gerrit-Owner: Jacob Garber
jgarber1@ualberta.ca
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: David Hendricks
david.hendricks@gmail.com
Gerrit-Reviewer: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: Jacob Garber
jgarber1@ualberta.ca
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 25 Jun 2019 11:59:20 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment