HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36694 )
Change subject: src/mb: Remove redundant message befor 'system_reset()'
......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/36694/1/src/northbridge/intel/nehal...
File src/northbridge/intel/nehalem/raminit.c:
https://review.coreboot.org/c/coreboot/+/36694/1/src/northbridge/intel/nehal...
PS1, Line 3670: printk(BIOS_DEBUG, "soft reset detected, rebooting properly\n");
Don't remove this. The write to MCHBAR is actually doing the reset. […]
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/36694
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id5a6b7c731b65aafbb88a7c52a1f434dbab41f4a
Gerrit-Change-Number: 36694
Gerrit-PatchSet: 3
Gerrit-Owner: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: Alexander Couzens
lynxis@fe80.eu
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Sat, 09 Nov 2019 10:55:22 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Arthur Heymans
arthur@aheymans.xyz
Gerrit-MessageType: comment