Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41889 )
Change subject: dptf: Add support for Fan Performance States ......................................................................
Patch Set 11:
(2 comments)
https://review.coreboot.org/c/coreboot/+/41889/10/src/acpi/acpigen_dptf.c File src/acpi/acpigen_dptf.c:
https://review.coreboot.org/c/coreboot/+/41889/10/src/acpi/acpigen_dptf.c@33... PS10, Line 338: _FPS
The fan objects are apparently defined in the ACPI spec itself, so this should in theory go in acpig […]
I thought about that, but as you pointed out, seems unused in coreboot. I'm a little surprised there isn't more use of the Thermal objects 😕
https://review.coreboot.org/c/coreboot/+/41889/10/src/acpi/acpigen_dptf.c@34... PS10, Line 342: percent
the volteer example does seem to have an entry with 0, does that mean it doesn't get written? shoul […]
Hmm, you're right, I suppose DPTF must care about the last field (power in this case), I will revise that check.