build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/28577 )
Change subject: nb/intel/x4x: Program read training results to all ranks
......................................................................
Patch Set 4:
(2 comments)
https://review.coreboot.org/#/c/28577/4/src/northbridge/intel/x4x/dq_dqs.c
File src/northbridge/intel/x4x/dq_dqs.c:
https://review.coreboot.org/#/c/28577/4/src/northbridge/intel/x4x/dq_dqs.c@4...
PS4, Line 454: * seems to be required, most likely because the signals can't really be generated
line over 80 characters
https://review.coreboot.org/#/c/28577/4/src/northbridge/intel/x4x/dq_dqs.c@5...
PS4, Line 526: /* Later on separate settings for each rank are used so program
line over 80 characters
--
To view, visit
https://review.coreboot.org/28577
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7965a068ef4779847e62e966154764370c91302a
Gerrit-Change-Number: 28577
Gerrit-PatchSet: 4
Gerrit-Owner: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Stefan Tauner
stefan.tauner@gmx.at
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Sun, 14 Oct 2018 11:25:50 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No