Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32798 )
Change subject: src/security/vboot/misc.h Fix clang fail to compile
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/#/c/32798/2/src/security/vboot/misc.h
File src/security/vboot/misc.h:
https://review.coreboot.org/#/c/32798/2/src/security/vboot/misc.h@92
PS2, Line 92: return
does it work to mark dead_code_assertion_failed_at_line_##line() as __attribute__((noreturn)) in assert.h? that way we don't have to rely on sprinkling spurious return statements across the tree.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/32798
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I19e0c9ba36f0ea5110480521a5f9afa0112a3137
Gerrit-Change-Number: 32798
Gerrit-PatchSet: 2
Gerrit-Owner: Alan Green
avg@google.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Alan Green
avg@google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Julius Werner
jwerner@chromium.org
Gerrit-CC: Patrick Georgi
pgeorgi@google.com
Gerrit-Comment-Date: Wed, 15 May 2019 17:53:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment