16 Aug
2019
16 Aug
'19
7:42 a.m.
Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33165 )
Change subject: mediatek: Use GPIO based SPI CS ......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/33165/2/src/soc/mediatek/common/inc... File src/soc/mediatek/common/include/soc/spi_common.h:
https://review.coreboot.org/c/coreboot/+/33165/2/src/soc/mediatek/common/inc... PS2, Line 81: gpio_t *cs_gpio;
Like mentioned in the depthcharge CL, I think we should just do this unconditionally. […]
Done
--
To view, visit https://review.coreboot.org/c/coreboot/+/33165
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I61653fb19242b6ee6be9a45545a8b66e5c9c7cad
Gerrit-Change-Number: 33165
Gerrit-PatchSet: 3
Gerrit-Owner: You-Cheng Syu youcheng@google.com
Gerrit-Reviewer: Hung-Te Lin hungte@chromium.org
Gerrit-Reviewer: Julius Werner jwerner@chromium.org
Gerrit-Reviewer: Mengqi Zhang Mengqi.Zhang@mediatek.com
Gerrit-Reviewer: You-Cheng Syu youcheng@google.com
Gerrit-Reviewer: Yu-Ping Wu yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Fri, 16 Aug 2019 05:42:37 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Julius Werner jwerner@chromium.org
Gerrit-MessageType: comment