Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30108 )
Change subject: mb/google/octopus/bobba: Add support to handle PEN_EJECT event
......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/#/c/30108/4/src/mainboard/google/octopus/variant...
File src/mainboard/google/octopus/variants/baseboard/gpio.c:
https://review.coreboot.org/#/c/30108/4/src/mainboard/google/octopus/variant...
PS4, Line 214: GPIO_145
Not for this CL, but we should also test if a single GPIO can be used for both wake and notifications here.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/30108
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I768b89d2b45f4dcab6d235b11ce00544a827f22d
Gerrit-Change-Number: 30108
Gerrit-PatchSet: 4
Gerrit-Owner: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Justin TerAvest
teravest@chromium.org
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Karthikeyan Ramasubramanian
kramasub@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Thu, 24 Jan 2019 04:42:12 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment