Attention is currently required from: Fabio Aiuto, Damien Zammit.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68103 )
Change subject: treewide: use helper to check if pci device is on n-th bus ......................................................................
Patch Set 2:
(1 comment)
File src/mainboard/emulation/qemu-i440fx/northbridge.c:
https://review.coreboot.org/c/coreboot/+/68103/comment/76360c68_0a93f46b PS2, Line 222: if (!is_pci_dev_on_bus(dev, 0)) This is equivalent to:
dev->bus->dev->path.type != DEVICE_PATH_PCI || dev->bus->secondary != 0
Whereas the original was:
dev->path.type != DEVICE_PATH_PCI || dev->bus->secondary != 0
Why involve the bus?