Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40424 )
Change subject: ec/google/chromeec: Add support for USB Type-C alternate mode control
......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/40424/2/src/ec/google/chromeec/acpi...
File src/ec/google/chromeec/acpi/cros_ec.asl:
https://review.coreboot.org/c/coreboot/+/40424/2/src/ec/google/chromeec/acpi...
PS2, Line 71: Name (_ADR, 0)
: Name (_DSD, Package () {
: ToUUID("daffd814-6eba-4d8c-8a91-bc9bbf4aa301"),
: Package() {
: Package () { "usb-role-switch",
: _SB.PCI0.PMC.MUX.CON0 },
: Package () { "mode-switch",
: _SB.PCI0.PMC.MUX.CON0 },
: Package () { "orientation-switch",
: _SB.PCI0.PMC.MUX.CON0 },
: Package () { "power-role", "dual" },
: Package () { "data-role", "dual" },
: }
: })
:
yes, thanks for the clarification. […]
Sounds good, let me know if you'd like me to take a look.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/40424
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I8c872537d9c633f8eb4238fd9b023577c4570a5a
Gerrit-Change-Number: 40424
Gerrit-PatchSet: 3
Gerrit-Owner: John Zhao
john.zhao@intel.com
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Aaron Durbin
adurbin@chromium.org
Gerrit-CC: Furquan Shaikh
furquan@google.com
Gerrit-CC: John Zhao
john.zhao@intel.corp-partner.google.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-CC: Prashant Malani
pmalani@google.com
Gerrit-Comment-Date: Fri, 24 Apr 2020 16:57:43 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: John Zhao
john.zhao@intel.com
Comment-In-Reply-To: Tim Wawrzynczak
twawrzynczak@chromium.org
Comment-In-Reply-To: Prashant Malani
pmalani@google.com
Gerrit-MessageType: comment