Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33884 )
Change subject: util/lint: check for Change-Id line presence and duplicates
......................................................................
Patch Set 2:
Patch Set 2:
I wrote this to fail tests, see https://review.coreboot.org/c/coreboot/+/30987
Should it end up in checkpatch.pl?
You mean to fail tests on jenkins? That should work since what-jenkins-does calls lint with --junit, which _should_ emit test results. I think something is broken there.
No need to touch checkpatch though.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/33884
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I67b9f134500bb596ae5790b68fe9f27e2fa2cfb4
Gerrit-Change-Number: 33884
Gerrit-PatchSet: 2
Gerrit-Owner: Idwer Vollering
vidwer@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Idwer Vollering
vidwer@gmail.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Wed, 17 Jul 2019 19:01:28 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment