Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33818 )
Change subject: vendorcode/intel/fsp/fsp2_0/cnl: Update FSP header files for Cannonlake
......................................................................
Patch Set 6:
Patch Set 6: Code-Review+1
(1 comment)
No idea, if the typos should be fixed upstream to not diverge.
Ideally, I think it would be good to fix the typos upstream. Less divergence would make it easy to sync in the future.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/33818
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If71e5fb8ae9f48a232b6b507e19145e1c06c2e83
Gerrit-Change-Number: 33818
Gerrit-PatchSet: 6
Gerrit-Owner: Bora Guvendik
bora.guvendik@intel.com
Gerrit-Reviewer: Bora Guvendik
bora.guvendik@intel.com
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Lijian Zhao
lijian.zhao@intel.com
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Selma Bensaid
selma.bensaid@intel.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-Comment-Date: Tue, 02 Jul 2019 14:16:21 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment