Hello Angel Pons, Arthur Heymans, David Hendricks, build bot (Jenkins), Patrick Georgi, Martin Roth,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/33409
to look at the new patch set (#2).
Change subject: nb/intel/x4x: Die on invalid memory speeds ......................................................................
nb/intel/x4x: Die on invalid memory speeds
The speed argument should be one of the six values from the mem_clock enum, so something is very wrong if this is not the case. Better to die now than return 0, which will cause a division-by-zero error later on where this function is called. The first two speeds are also unsupported and have the same problem with returning 0, so die on those as well.
Change-Id: Ib628c0eed3d6571bdde1df27ae213ca0691ec256 Signed-off-by: Jacob Garber jgarber1@ualberta.ca Found-by: Coverity CID 1391088 --- M src/northbridge/intel/x4x/raminit_ddr23.c 1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/09/33409/2