[coreboot-gerrit] Change in ...coreboot[master]: timestamp: Move timestamp_should_run() call

[Patrick Georgi (Code Review)]

Patrick Georgi has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/31524 )

Change subject: timestamp: Move timestamp_should_run() call
......................................................................

timestamp: Move timestamp_should_run() call

Old location caused spurious error messages when
called from APs, where timestamp_add_now() should
do nothing.

Moving the test also makes get_us_from_boot() usable
from APs (assuming cache coherency).

Change-Id: Ice9ece11b15bbe1a58a038cda3d299862e6f822b
Signed-off-by: Kyösti Mälkki 
Reviewed-on: https://review.coreboot.org/c/31524
Reviewed-by: Aaron Durbin 
Reviewed-by: Furquan Shaikh 
Reviewed-by: Werner Zeh 
Reviewed-by: Julius Werner 
Tested-by: build bot (Jenkins) 
---
M src/lib/timestamp.c
1 file changed, 3 insertions(+), 3 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Aaron Durbin: Looks good to me, approved
  Werner Zeh: Looks good to me, but someone else must approve
  Furquan Shaikh: Looks good to me, approved
  Julius Werner: Looks good to me, but someone else must approve

diff --git a/src/lib/timestamp.c b/src/lib/timestamp.c
index 6885e7b..f84b9d5 100644
--- a/src/lib/timestamp.c
+++ b/src/lib/timestamp.c
@@ -125,9 +125,6 @@
    MAYBE_STATIC struct timestamp_table *ts_table = NULL;
    struct timestamp_cache *ts_cache;

-	if (!timestamp_should_run())
-		return NULL;
-
    if (ts_table != NULL)
    	return ts_table;

@@ -188,6 +185,9 @@
 {
    struct timestamp_table *ts_table;

+	if (!timestamp_should_run())
+		return;
+
    ts_table = timestamp_table_get();

if (!ts_table) {