Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/27483 )
Change subject: sdm845: Add SPI QUP driver
......................................................................
Patch Set 52:
We are thinking to create a new folder "include" inside depthcharge/src/drivers/bus, to keep all the common files there. What do you say about it?
I think depthcharge/src/drivers/soc/qcom_qup_se.[h|c] would probably be the best location.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/27483
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I35061727d5ccc550eaeb06caef4524bc4cf25b54
Gerrit-Change-Number: 27483
Gerrit-PatchSet: 52
Gerrit-Owner: T.Michael Turney
tturne@codeaurora.org
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Mukesh Savaliya
msavaliy@qualcomm.corp-partner.google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: T.Michael Turney
tturne@codeaurora.org
Gerrit-Reviewer: Vin Kamath
vink@codeaurora.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: mturney mturney
mturney@codeaurora.org
Gerrit-CC: Akash Asthana
akashast@qualcomm.corp-partner.google.com
Gerrit-CC: Julius Werner
jwerner@chromium.org
Gerrit-Comment-Date: Fri, 03 May 2019 21:42:15 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment