[coreboot-gerrit] Change in coreboot[master]: lib/cbfs: Add fallback to RO region to cbfs_boot_locate

[Wim Vervoorn (Code Review)]

Wim Vervoorn has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36545 )

Change subject: lib/cbfs: Add fallback to RO region to cbfs_boot_locate
......................................................................

Patch Set 1:

(1 comment)

https://review.coreboot.org/c/coreboot/+/36545/1//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/36545/1//COMMIT_MSG@11 
PS1, Line 11: static files that are not intended to be updated to the RW regions.
> Done

I touched done by mistake above. So please ignore that.

I had a look. The RO_NORMAL support isn't present in coreboot and the definition of VB2_FIRMWARE_PREAMBLE_USE_RO_NORMAL indicates this shouldn't be used.

Can you indicate why implementing an optional fallback mechanism is a problem? Basically this allows us to provide the functionality having a single change and a single option to enable/disable. Providing a fall back for every single file would require more changes at more locations to provide the same result.