[coreboot-gerrit] [M] Change in coreboot[main]: intel/common/block: Program the right power_limits_config entry

[Jérémy Compostella (Code Review)]

Attention is currently required from: Dinesh Gehlot, Eran Mitrani, Jakub Czapiga, Jérémy Compostella, Kapil Porwal, Subrata Banik, Tarun.

Hello Dinesh Gehlot, Eran Mitrani, Jakub Czapiga, Kapil Porwal, Subrata Banik, Tarun, build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/85244?usp=email

to look at the new patch set (#10).

Change subject: intel/common/block: Program the right power_limits_config entry
......................................................................

intel/common/block: Program the right power_limits_config entry

When variant_update_cpu_power_limits() programs PL4, it systematically
sets the first entry of the power_limits_config SoC chip data
structure, while the current SoC SKU may be tied to another entry.

This commit introduces a new soc_get_sku_power_limits() API that
variant_update_cpu_power_limits() uses to retrieve the correct power
limits entry. This function must be supported by the SoC code and
return a pointer to the current SKU SoC power limits data structure.

Luckily, this bug did not lead to any issues as it has only been used
with SKUs whose power limits are in the first entry or to program a
PL4 value identical to the default value.

This CL also updates the documentation of
variant_update_cpu_power_limits() to fix a typo and provides some
extra details on the performed operations.

BUG=b:380408956
TEST=TBD

Change-Id: I32de8a24a2b5aee3eb5a6eee2d1d91e203085e65
Signed-off-by: Jeremy Compostella 
---
M src/soc/intel/common/block/include/intelblocks/power_limit.h
M src/soc/intel/common/block/power_limit/power_limit.c
M src/soc/intel/meteorlake/systemagent.c
3 files changed, 52 insertions(+), 29 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/44/85244/10