Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47051 )
Change subject: mb/purism/librem_cnl: Adjust in preparation for new variants ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/47051/1/src/mainboard/purism/librem... File src/mainboard/purism/librem_cnl/Kconfig.name:
https://review.coreboot.org/c/coreboot/+/47051/1/src/mainboard/purism/librem... PS1, Line 4: select SOC_INTEL_WHISKEYLAKE
Hatch only has to deal with one type of SoC. I'm not sure what your point is.
Right, but it shows how different boards can select different options, while having a common section (BOARD_GOOGLE_HATCH_COMMON, BOARD_GOOGLE_BASEBOARD_PUFF, BOARD_GOOGLE_BASEBOARD_HATCH).
Personally, I prefer to have mainboards select non-common options in Kconfig.name instead of piling up conditional selects in Kconfig
I don't, because it's wrong. Kconfig.name ist not meant for selecting anything but shall just be used for the names in choice (as the filename already says). This is documented btw. `Documentation/getting_started/kconfig.md`. I know there are boards doing that, but it's not right.
If we want to split it to different Kconfig, the right way would be having `board/variant/*/Kconfig`, which overrides options in `board/Kconfig` per variant.