Attention is currently required from: Martin L Roth, Tim Wawrzynczak, Julius Werner. Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/64657 )
Change subject: cbfstool: Expand CBFS verification validity check ......................................................................
Patch Set 2:
(4 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/64657/comment/b4e5ce29_7b62e034 PS1, Line 12: catch
I tested on corsola and it didn't catch the issue.
PS2 works! Thanks.
File Makefile.inc:
https://review.coreboot.org/c/coreboot/+/64657/comment/51b76e44_7b87dccd PS2, Line 1173: [ [
Otherwise we're matching any characters inside the brackets.
File util/cbfstool/cbfstool.c:
https://review.coreboot.org/c/coreboot/+/64657/comment/16050e29_fb61fc76 PS2, Line 1505: (void)dev; If this is about the unused-variable error, can we use __unused?
https://review.coreboot.org/c/coreboot/+/64657/comment/2d43695d_f161e2a6 PS2, Line 1542: vb2_digest_size Indentation.