Philipp Hug has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35246 )
Change subject: mb/emulation/qemu-riscv: Implement ipi using clint to enable smp in qemu/spike.
......................................................................
Patch Set 3:
Patch Set 3: Code-Review+1
(1 comment)
yes it is necessary:
src/mainboard/emulation/qemu-riscv/clint.c:30:10: error: cast to pointer from integer of different size [-Werror=int-to-pointer-cast]
--
To view, visit
https://review.coreboot.org/c/coreboot/+/35246
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I94fb25fad103e3cb5db676eb4caead11d54ae0ae
Gerrit-Change-Number: 35246
Gerrit-PatchSet: 3
Gerrit-Owner: Philipp Hug
philipp@hug.cx
Gerrit-Assignee: Patrick Rudolph
patrick.rudolph.100@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Philipp Hug
philipp@hug.cx
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: ron minnich
rminnich@gmail.com
Gerrit-CC: Patrick Rudolph
patrick.rudolph.100@gmail.com
Gerrit-Comment-Date: Thu, 12 Sep 2019 08:56:11 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment