Arthur Heymans has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/82102?usp=email )
Change subject: Makefile.mk: Align romstage to page directory pointer requirements ......................................................................
Makefile.mk: Align romstage to page directory pointer requirements
On x86_64 romstage can contain page tables and a page table pointer which have an larger alignment requirement.
Change-Id: I94e4a4209b7441ecb2966a1342c3d46625771bb8 Signed-off-by: Arthur Heymans arthur@aheymans.xyz --- M Makefile.mk 1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/02/82102/1
diff --git a/Makefile.mk b/Makefile.mk index e642ac7..c476afb 100644 --- a/Makefile.mk +++ b/Makefile.mk @@ -1276,7 +1276,7 @@ $(CONFIG_CBFS_PREFIX)/romstage-options := -b 0 endif ifeq ($(CONFIG_ARCH_ROMSTAGE_X86_32)$(CONFIG_ARCH_ROMSTAGE_X86_64),y) -# Use a 64 byte alignment to provide a minimum alignment +# Use a 4096 byte alignment to provide a minimum alignment # requirement for the overall romstage. While the first object within # romstage could have a 4 byte minimum alignment that doesn't mean the linker # won't decide the entire section should be aligned to a larger value. In the @@ -1284,7 +1284,7 @@ # requirements of the program segment. # # Make sure that segment for .car.data is ignored while adding romstage. -$(CONFIG_CBFS_PREFIX)/romstage-align := 64 +$(CONFIG_CBFS_PREFIX)/romstage-align := 4096 ifeq ($(CONFIG_NO_XIP_EARLY_STAGES),y) $(CONFIG_CBFS_PREFIX)/romstage-options := -S ".car.data" else