Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38836 )
Change subject: security/intel/stm: Check for processor STM support
......................................................................
Patch Set 5: Code-Review+1
(1 comment)
https://review.coreboot.org/c/coreboot/+/38836/5/src/include/cpu/x86/msr.h
File src/include/cpu/x86/msr.h:
https://review.coreboot.org/c/coreboot/+/38836/5/src/include/cpu/x86/msr.h@7...
PS5, Line 77: 17
It's documented as bit 49, so `(49 - 32)` is be preferred, cf. MCA_STATUS_HI_*.
Also, how about naming it VMX_BASIC_HI_DUAL_MONITOR? or at least give it some
VMX_ prefix.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/38836
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I518bb2aa1bdec94b5b6d5e991d7575257f3dc6e9
Gerrit-Change-Number: 38836
Gerrit-PatchSet: 5
Gerrit-Owner: cedarhouse1@comcast.net
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Nicolas Reinecke
nr@das-labor.org
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: cedarhouse1@comcast.net
Gerrit-Reviewer: ron minnich
rminnich@gmail.com
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 20 Feb 2020 14:40:58 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment