Benjamin Doron has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47116 )
Change subject: soc/intel/skylake: Enable PCH thermal depending on devicetree ......................................................................
Patch Set 4:
(2 comments)
https://review.coreboot.org/c/coreboot/+/47116/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/47116/2//COMMIT_MSG@1 PS2, Line 1: Parent: 9c1c0096 (soc/intel/skylake: Enable thermal subsystem depending on devicetree)
Rebase on master?
Done
https://review.coreboot.org/c/coreboot/+/47116/2/src/soc/intel/skylake/chip.... File src/soc/intel/skylake/chip.c:
https://review.coreboot.org/c/coreboot/+/47116/2/src/soc/intel/skylake/chip.... PS2, Line 285: params->PchThermalDeviceEnable = dev && dev->enabled;
According to Kaby Lake Fsp.bsf [1], it's enabled by default. […]
The current behaviour may have forced boards to enable the device to follow FSP, but this is preserving the current behaviour.