Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39306 )
Change subject: cbfs: Introduce cbfs_ro_map() and cbfs_ro_load()
......................................................................
Patch Set 6:
(2 comments)
https://review.coreboot.org/c/coreboot/+/39306/4/src/drivers/pc80/rtc/option...
File src/drivers/pc80/rtc/option.c:
https://review.coreboot.org/c/coreboot/+/39306/4/src/drivers/pc80/rtc/option...
PS4, Line 53: truct region_device *rdev
What's this parameter for now?
Whoops, yes, looks this doesn't get built by default and I missed some stuff. Fixed.
https://review.coreboot.org/c/coreboot/+/39306/4/src/drivers/pc80/rtc/option...
PS4, Line 55: ct
This should be a pointer?
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/39306
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I9c55b022b6502a333a9805ab0e4891dd7b97ef7f
Gerrit-Change-Number: 39306
Gerrit-PatchSet: 6
Gerrit-Owner: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Fri, 02 Oct 2020 22:36:12 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Aaron Durbin
adurbin@chromium.org
Gerrit-MessageType: comment