Attention is currently required from: Martin Roth, Subrata Banik, Andrey Petrov, Patrick Rudolph.
Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52867 )
Change subject: drivers/intel/fsp2_0: Add timestamps for loading FSPM & FSPS
......................................................................
Patch Set 4:
(1 comment)
File src/commonlib/include/commonlib/timestamp_serialized.h:
https://review.coreboot.org/c/coreboot/+/52867/comment/14899d3c_6f7af1a5
PS4, Line 122: TS_FSP_MEMORY_INIT_LOAD
What would you think about adding a _START and _END. I think it makes it easier to grok the timestamp data.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/52867
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I5796d4cdd512799c2eafee45a8ef561de5258b91
Gerrit-Change-Number: 52867
Gerrit-PatchSet: 4
Gerrit-Owner: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Andrey Petrov
andrey.petrov@gmail.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Raul Rangel
rrangel@chromium.org
Gerrit-Attention: Martin Roth
martinroth@google.com
Gerrit-Attention: Subrata Banik
subrata.banik@intel.com
Gerrit-Attention: Andrey Petrov
andrey.petrov@gmail.com
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Comment-Date: Tue, 18 May 2021 15:11:42 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment