Attention is currently required from: Ravi kumar, Paul Menzel, Julius Werner, mturney mturney.
Ravi Kumar Bokka has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45206 )
Change subject: herobrine: sc7280: Provide initial mainboard support
......................................................................
Patch Set 46:
(2 comments)
File src/mainboard/google/herobrine/Kconfig:
https://review.coreboot.org/c/coreboot/+/45206/comment/28847268_12e6bf1a
PS45, Line 1:
Please remove the blank line at the top.
Done
File src/mainboard/google/herobrine/chromeos.fmd:
https://review.coreboot.org/c/coreboot/+/45206/comment/dab2adec_c717de79
PS45, Line 3: # TODO: update for Herobrine
All copied files originated in trogdor directory.
Ack
--
To view, visit
https://review.coreboot.org/c/coreboot/+/45206
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I428cf1a461ee63215f5683abbfed90202d1b2a88
Gerrit-Change-Number: 45206
Gerrit-PatchSet: 46
Gerrit-Owner: Ravi kumar
rbokka@codeaurora.org
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: mturney mturney
mturney@codeaurora.org
Gerrit-CC: Julius Werner
jwerner@chromium.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-CC: Ravi Kumar Bokka
c_rbokka@qualcomm.corp-partner.google.com
Gerrit-CC: Shelley Chen
shchen@google.com
Gerrit-Attention: Ravi kumar
rbokka@codeaurora.org
Gerrit-Attention: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Attention: Julius Werner
jwerner@chromium.org
Gerrit-Attention: mturney mturney
mturney@codeaurora.org
Gerrit-Comment-Date: Tue, 06 Apr 2021 11:55:51 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@users.sourceforge.net
Comment-In-Reply-To: mturney mturney
mturney@codeaurora.org
Gerrit-MessageType: comment
