Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33193 )
Change subject: soc/intel/{cml, whl}: Add option to skip HECI function disable in SMM ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/#/c/33193/1/src/soc/intel/cannonlake/Kconfig File src/soc/intel/cannonlake/Kconfig:
https://review.coreboot.org/#/c/33193/1/src/soc/intel/cannonlake/Kconfig@30 PS1, Line 30: CHROMEOS
Is this really the right check?
Duncan, i think real use of this config would be like 1. WHL and CML platform will select SKIP_HECI_FUNCTION_DISABLE_USING_SMM from soc kconfig 2. HeciEnable=0 3. Make use of this CL https://review.coreboot.org/c/coreboot/+/32992
I don't think #3 one is merged yet.
Calling this code today makes my WHL system hang,
Do you mean code is still entering into "pch_disable_heci()" for WHL platform ? and this function is causing hang?
I have verified that on WHL and CML, now pch_disable_heci() function won't get call due to below checks
if (!config->HeciEnabled && !CONFIG(SKIP_HECI_FUNCTION_DISABLE_USING_SMM)) pch_disable_heci();
regardless of whether CONFIG_CHROMEOS is enabled or not.