Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41898 )
Change subject: soc/amd/picasso: solve MTRRs only from 4GiB and below ......................................................................
Patch Set 4:
Patch Set 4:
It sounded like there was something goofed with yesterday's CQ ordering and many people were seeing problems. So hopefully if you give it another try it'll be OK. I did a repo sync Saturday morning and checked it on Mandolin. I rebased these 3 changes on top of 524962 and cherry-picked CB:33772. I'm not seeing the problems you're reporting. Also FWIW I verified the MTRRs are unmodified during the two FSP calls.
Ok, I'll retry that later today with a fresh FSP repo checkout. Only had 1 new MTRR related change in my FSP repo checkout when I built that yesterday; might be the cause of the issues
Felix, were you able to verify things? Yes, in the chromium repos I messed up and didn't incorporate the new cq-depend syntax which caused things to land unatomically.