build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/24992 )
Change subject: lib: Add blob_provider functionality ......................................................................
Patch Set 11:
(30 comments)
https://review.coreboot.org/#/c/24992/11/src/include/blob_provider.h File src/include/blob_provider.h:
https://review.coreboot.org/#/c/24992/11/src/include/blob_provider.h@32 PS11, Line 32: ID_ACPI_SLIC, please, no spaces at the start of a line
https://review.coreboot.org/#/c/24992/11/src/include/blob_provider.h@33 PS11, Line 33: ID_ACPI_DSDT, please, no spaces at the start of a line
https://review.coreboot.org/#/c/24992/11/src/include/blob_provider.h@34 PS11, Line 34: ID_ACPI_SSDT, please, no spaces at the start of a line
https://review.coreboot.org/#/c/24992/11/src/include/blob_provider.h@35 PS11, Line 35: ID_MICROCODE, please, no spaces at the start of a line
https://review.coreboot.org/#/c/24992/11/src/include/blob_provider.h@36 PS11, Line 36: ID_MICROCODE_RMU, please, no spaces at the start of a line
https://review.coreboot.org/#/c/24992/11/src/include/blob_provider.h@37 PS11, Line 37: ID_MRC_CACHE, please, no spaces at the start of a line
https://review.coreboot.org/#/c/24992/11/src/include/blob_provider.h@38 PS11, Line 38: ID_VGA_VBT, please, no spaces at the start of a line
https://review.coreboot.org/#/c/24992/11/src/include/blob_provider.h@39 PS11, Line 39: ID_NVRAM_CMOS_LAYOUT, please, no spaces at the start of a line
https://review.coreboot.org/#/c/24992/11/src/include/blob_provider.h@40 PS11, Line 40: ID_NVRAM_CMOS_DEFAULT, please, no spaces at the start of a line
https://review.coreboot.org/#/c/24992/11/src/include/blob_provider.h@41 PS11, Line 41: ID_NVRAM_VPD, please, no spaces at the start of a line
https://review.coreboot.org/#/c/24992/11/src/include/blob_provider.h@42 PS11, Line 42: ID_SPD, please, no spaces at the start of a line
https://review.coreboot.org/#/c/24992/11/src/include/blob_provider.h@43 PS11, Line 43: ID_MAC, please, no spaces at the start of a line
https://review.coreboot.org/#/c/24992/11/src/include/blob_provider.h@44 PS11, Line 44: ID_AMD_S3NV, please, no spaces at the start of a line
https://review.coreboot.org/#/c/24992/11/src/include/blob_provider.h@45 PS11, Line 45: ID_MRC_CACHE_RW_REGION, please, no spaces at the start of a line
https://review.coreboot.org/#/c/24992/11/src/include/blob_provider.h@46 PS11, Line 46: ID_NVRAM_VPD_RO_REGION, please, no spaces at the start of a line
https://review.coreboot.org/#/c/24992/11/src/include/blob_provider.h@47 PS11, Line 47: ID_AMD_AGESA, please, no spaces at the start of a line
https://review.coreboot.org/#/c/24992/11/src/include/blob_provider.h@48 PS11, Line 48: ID_AMD_AGESA_PRE_MEM, please, no spaces at the start of a line
https://review.coreboot.org/#/c/24992/11/src/include/blob_provider.h@49 PS11, Line 49: ID_AMD_AGESA_POST_MEM, please, no spaces at the start of a line
https://review.coreboot.org/#/c/24992/11/src/include/blob_provider.h@50 PS11, Line 50: ID_AMD_PSP, please, no spaces at the start of a line
https://review.coreboot.org/#/c/24992/11/src/include/blob_provider.h@51 PS11, Line 51: ID_INTEL_MRC, please, no spaces at the start of a line
https://review.coreboot.org/#/c/24992/11/src/include/blob_provider.h@52 PS11, Line 52: ID_INTEL_FSP_S, please, no spaces at the start of a line
https://review.coreboot.org/#/c/24992/11/src/include/blob_provider.h@53 PS11, Line 53: ID_INTEL_FSP_M, please, no spaces at the start of a line
https://review.coreboot.org/#/c/24992/11/src/include/blob_provider.h@54 PS11, Line 54: ID_INTEL_MMA, please, no spaces at the start of a line
https://review.coreboot.org/#/c/24992/11/src/include/blob_provider.h@55 PS11, Line 55: ID_NVIDIA_MTC, please, no spaces at the start of a line
https://review.coreboot.org/#/c/24992/11/src/include/blob_provider.h@56 PS11, Line 56: ID_QUALCOMM_CDT, please, no spaces at the start of a line
https://review.coreboot.org/#/c/24992/11/src/include/blob_provider.h@57 PS11, Line 57: ID_QUALCOMM_DDR, please, no spaces at the start of a line
https://review.coreboot.org/#/c/24992/11/src/include/blob_provider.h@58 PS11, Line 58: ID_QUALCOMM_TZ, please, no spaces at the start of a line
https://review.coreboot.org/#/c/24992/11/src/include/blob_provider.h@59 PS11, Line 59: ID_QUALCOMM_RPM, please, no spaces at the start of a line
https://review.coreboot.org/#/c/24992/11/src/lib/blob_provider.c File src/lib/blob_provider.c:
https://review.coreboot.org/#/c/24992/11/src/lib/blob_provider.c@71 PS11, Line 71: if (lookup_rdev(locator, &data) < 0) { braces {} are not necessary for single statement blocks
https://review.coreboot.org/#/c/24992/11/src/lib/blob_provider.c@84 PS11, Line 84: if (lookup_rdev(locator, data) < 0) { braces {} are not necessary for single statement blocks